Issue 1083645: Tests fail instead of skip (original) (raw)

Created on 2004-12-11 23:06 by dvch, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (8)
msg23653 - (view)	Author: Detlef Vollmann (dvch)	Date: 2004-12-11 23:06
On Linux, with threads disabled (--with-threads=no), the tests test_imp, test_list and test_userlist fail instead of skipping.
msg23654 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2004-12-18 04:33
Logged In: YES user_id=357491 Can you run these tests individually and save the output to see how they are failing?
msg23655 - (view)	Author: Detlef Vollmann (dvch)	Date: 2004-12-18 11:48
Logged In: YES user_id=729909 Sorry, from the short output of 'make test' the problem seemed obvious: test_imp test test_imp failed -- expected imp.lock_held() to be True ... test_list ImportError: No module named thread ... test_userlist ImportError: No module named thread But after running the tests manually, I noticed that the latter two tests are complete test packs. The complete output is attached. Detlef
msg23656 - (view)	Author: Raymond Hettinger (rhettinger) *	Date: 2004-12-18 14:34
Logged In: YES user_id=80475 Please try out the attached patch and let me know if the full test_suite passes.
msg23657 - (view)	Author: Detlef Vollmann (dvch)	Date: 2004-12-18 16:04
Logged In: YES user_id=729909 test_list and test_userlist succeed now, great, thanks. test_imp still fails as before :-( Detlef
msg23658 - (view)	Author: Raymond Hettinger (rhettinger) *	Date: 2004-12-18 19:41
Logged In: YES user_id=80475 Applied the decimal fixup. It is no longer dependent on threads. See Lib/decimal.py 1.32 and 1.31.2.1 Am unassigning myself for the rest. It's not an especially high priority to teach regrtest.py about tests that should be skipped when there are no threads.
msg23659 - (view)	Author: Brett Cannon (brett.cannon) *	Date: 2004-12-18 21:10
Logged In: YES user_id=357491 test_imp is now skipped on platforms that don't have threading. Covered by rev. 1.5 in HEAD, rev. 1.4.14.1 for 2.4, and rev. 1.4.10.1 for 2.3 . This takes care of all the reported tests.
msg23660 - (view)	Author: Detlef Vollmann (dvch)	Date: 2004-12-19 00:22
Logged In: YES user_id=729909 I just tested the patch and it works fine: it correcly skips test_imp :-) Thanks Detlef