Issue 1094164: xml.dom.minidom.Node.replaceChild(obj, x, x) removes child x (original) (raw)

Issue1094164

Created on 2005-01-01 19:43 by xitnalta, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
minidom.py.patch xitnalta,2005-01-01 19:43
Messages (3)
msg47443 - (view) Author: Felix Rabe (xitnalta) Date: 2005-01-01 19:43
A child was removed from a node if an attempt was made to replace it with itself. The cause was the comparison "if newChild is oldChild:" happening too late in the function's code, so I moved it before the "newChild.parentNode" check.
msg47444 - (view) Author: Felix Rabe (xitnalta) Date: 2005-01-01 19:45
Logged In: YES user_id=163986 The patch applies to CVS python/dist/src checked out half an hour ago.
msg47445 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2005-11-22 19:05
Logged In: YES user_id=11375 Good catch; thanks! Patch applied to HEAD and to release24-maint.
History
Date User Action Args
2022-04-11 14:56:08 admin set github: 41386
2005-01-01 19:43:57 xitnalta create