Issue 1100294: Log gc times when DEBUG_STATS set (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/41424

classification

Title: Log gc times when DEBUG_STATS set
Type: Stage:
Components: Library (Lib) Versions: Python 2.5

process

Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: barry Nosy List: barry, skip.montanaro
Priority: normal Keywords: patch

Created on 2005-01-11 17:11 by skip.montanaro, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
gc.diff skip.montanaro,2006-02-24 02:22
Messages (6)
msg47506 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2005-01-11 17:11
The attached patch adds collection time to the information the garbage collector prints when DEBUG_STATS is enabled. I was more-or-less challenged at work to show that garbage collection wouldn't cripple our long-running, high-performance servers at crucial times. This seemed the best way to demonstrate that it didn't present a problem.
msg47507 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2006-02-23 17:01
Logged In: YES user_id=12800 There's no patch here; are you sure you checked the checkbox? I'm actually putzing around in gcmodule.c atm to address some related issues and I'd be willing to review this patch if you attach it again.
msg47508 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2006-02-24 02:22
Logged In: YES user_id=44345 Must not have had the box checked. Thank goodness I almost never delete files in ~/tmp/... Skip
msg47509 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2006-03-06 04:26
Logged In: YES user_id=12800 Looks pretty good. I wonder if you should call PyErr_Clear() when the import or call fails? Other than that, +1
msg47510 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2006-04-02 00:45
Logged In: YES user_id=12800 Sorry it's taken so long to review this. +1. I say go ahead and apply it to Py 2.5.
msg47511 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2006-04-21 01:34
Logged In: YES user_id=44345 checked in as rev 45590.
History
Date User Action Args
2022-04-11 14:56:09 admin set github: 41424
2005-01-11 17:11:52 skip.montanaro create