Issue 1100563: ast-branch: fix for coredump from new import grammar (original) (raw)

Issue1100563

Created on 2005-01-12 00:50 by logistix, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
24_import_grammar.diff logistix,2005-01-12 00:50 patch for new import grammar in ast-branch
Messages (3)
msg47513 - (view) Author: Grant Olson (logistix) Date: 2005-01-12 00:50
New import grammar causes a coredump in the ast- branch. Attached is a fix. After this is applied we start getting coredumps from generator expressions in the test suite. I'm reasonably sure (and correct me if I'm wrong) that the generator expressions fix is more elaborate, as it requires patches to the bytecode generation as well.
msg47514 - (view) Author: Kurt B. Kaiser (kbk) * (Python committer) Date: 2005-01-17 04:05
Logged In: YES user_id=149084 Neal has checked in a fix to ast.c which corrects the coredump due to import errors. This dump was first seen after merging trunk to ast-branch 07Jan05. This patch is out of date and at this point represents a different refactoring than what Neal has done.
msg47515 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2005-01-17 14:16
Logged In: YES user_id=33168 Sorry, I didn't realize this patch existed before fixing import. This patch looks like it might be a bit cleaner. As for the genexpr fix, yes, it is much more involved. I added some support to move things along. At this point what's required is to use the original patches and mold into the new AST code. The original checkin that is most important is here: http://mail.python.org/pipermail/python-checkins/2004-May/040900.html
History
Date User Action Args
2022-04-11 14:56:09 admin set github: 41429
2005-01-12 00:50:02 logistix create