Issue 1231069: ioctl has problem with -ive request codes (original) (raw)

Issue1231069

Created on 2005-07-01 16:24 by barry-scott, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
fcntlmodule.patch	barry-scott,2005-07-01 16:24	Patch against python 2..4.1

Messages (4)
msg25701 - (view)	Author: Barry Alan Scott (barry-scott) *	Date: 2005-07-01 16:24
On Linux many ioctl request code values cannot be passed to ioctl because it assumes that the values are signed ints. Value with the top bit set 0x8000000 are common. Changing the PyArg_ParseTuple calls to use "I" instead of "i" fixes the problem. This may well also be the issue with bug 1112949 "ioctl has problems on 64 bit machines". The attached patch fixes the problem in 2.4.1 and was tested on FC4.
msg25702 - (view)	Author: Michael Hudson (mwh)	Date: 2005-07-03 14:50
Logged In: YES user_id=6656 The patch seems to be empty (!?) Good idea, although not goo enough for me to fight CVS over dialup...
msg25703 - (view)	Author: Barry Alan Scott (barry-scott) *	Date: 2005-07-18 10:57
Logged In: YES user_id=28665 I've messed up attchments on SF before but the patch downloads for me. Barry
msg25704 - (view)	Author: Michael Hudson (mwh)	Date: 2005-07-27 20:25
Logged In: YES user_id=6656 Finally committed this as: Modules/fcntlmodule.c revision 2.44 Misc/NEWS revision 1.1326 Thanks, and sorry for the delay...