| msg48811 - (view) |
Author: chads (cjschr) |
Date: 2005-09-30 15:32 |
| Implementation of a BSD-style wait4() function, which is similar to waitpid, but it also returns resource usage information about the child process. wait4(pid, options) -> (pid, status, rusage) Chad |
|
|
| msg48812 - (view) |
Author: Neal Norwitz (nnorwitz) *  |
Date: 2005-10-01 03:16 |
| Logged In: YES user_id=33168 Chad, I'm starting to look at this now, but it seems to be a duplicate of your original patch # 1000267. Can this be closed as a duplicate? I don't know if the attachments are the same. It would be easier to have all the changes in a single file. Since you are adding a new file, you will need to use -N option to cvs diff. Something like this: cvs diff -Nu ... (you can list the specific files that changed if necessary). From what I looked at so far, there were a couple of things I didn't like. Though it looks like you addressed many (perhaps all) of the previous comments. I don't like the code in resourcemodule.h. I would prefer a public API in resourcemodule that posixmodule can call. If you think that no other modules outside python should call this, you can prefix the name with _, ie _PyResourceModule_...(). There are some un-prefixed names in resourcemodule.h. I think these may all go away if you move the code into the .c file. I would prefer to not have resourcemodule_h_author & resourcemodule_h_rcsid. The comment with your name and email is fine. I didn't look at the test or usage example. What should be done with the usage example? In the doc, could you remove the ", ?" for availability. We can leave it as Unix for now. If we find out definitive info about other platforms (Windows, Mac), we can add that later. Please add a \versionadded{2.5} at the end of the new doc (before the end). That's all my comments. This looks close to being ready. |
|
|
| msg48813 - (view) |
Author: Neal Norwitz (nnorwitz) * |
Date: 2005-10-02 21:56 |
| Logged In: YES user_id=33168 Comments from author received in mail: It is a duplicate of my original post, but it was diff'ed against the latest CVS tree. The usage example is for those who haven't had experience with wait4 before, hence the name. It's an FYI, nothing more. I'll also update the documentation accordingly. |
|
|
| msg48814 - (view) |
Author: chads (cjschr) |
Date: 2006-01-17 22:52 |
| Logged In: YES user_id=1093928 Took a different approach with implementation. Also includes wait3 implementation. LMK how it looks. Thanks. Chad |
|
|
| msg48815 - (view) |
Author: Neal Norwitz (nnorwitz) * |
Date: 2006-01-19 06:58 |
| Logged In: YES user_id=33168 I looked over the patch. It looks pretty good. Can your provide doc too? If you can't do latex, just text will do and I'll convert. Doc/lib/libos.tex |
|
|
| msg48816 - (view) |
Author: chads (cjschr) |
Date: 2006-01-19 13:47 |
| Logged In: YES user_id=1093928 Neil Check the diff. Doc updates are already there. Thanks. |
|
|
| msg48817 - (view) |
Author: Neal Norwitz (nnorwitz) * |
Date: 2006-03-18 22:18 |
| Logged In: YES user_id=33168 I think I recall spotting the docs after your comment. I plan to get this in before alpha1. |
|
|
| msg48818 - (view) |
Author: Neal Norwitz (nnorwitz) * |
Date: 2006-03-20 06:31 |
| Logged In: YES user_id=33168 Thanks for the patch! Finally applied (with mods). Committed revision 43158. |
|
|
| msg48819 - (view) |
Author: chads (cjschr) |
Date: 2006-04-04 13:36 |
| Logged In: YES user_id=1093928 I like what you did with the posixmodule. Great work! Thanks for all your help getting this added. |
|
|