Issue 1355883: make depend/clean issues w/ ast (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/42588

classification

process

Created on 2005-11-13 13:27 by skip.montanaro, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (7)
msg26866 - (view)	Author: Skip Montanaro (skip.montanaro) *	Date: 2005-11-13 13:27
I noticed two issues with the ast vis a vis building and cleaning. Haven't had a chance to look into them, however... 1. From a fresh checkout, execute configure, then "make -j2". It will run Parser/asdl_c.py twice simultaneously. This can obviously lead to corrupt Python-ast.[ch] files. 2. Neither "make clean" nor "make distclean" delete the Python-ast.[ch] files. "make distclean" at least should.
msg26867 - (view)	Author: Thomas Lee (krumms)	Date: 2005-11-13 16:24
Logged In: YES user_id=315535 The first problem is being caused by a simple misunderstanding/oversight in Makefile.pre.in. The rule for a target will be called for each target. In our case, we have Python-ast.h and Python-ast.c in our list of targets. So asdl_c.py gets called once for each target. Hope this makes sense. :) If not I can bang up a patch so you can at least see what I'm on about.
msg26868 - (view)	Author: Skip Montanaro (skip.montanaro) *	Date: 2005-11-13 16:44
Logged In: YES user_id=44345 I was thinking it might be something like that. Perhaps asdl_c.py should be modified to accept an output flag (--output=[hc] or -h/-c) so it only generates one file or the other.
msg26869 - (view)	Author: Thomas Lee (krumms)	Date: 2005-11-13 16:45
Logged In: YES user_id=315535 Already on it :) Shall have a patch up shortly.
msg26870 - (view)	Author: Thomas Lee (krumms)	Date: 2005-11-13 16:58
Logged In: YES user_id=315535 Fix for part 1 here: http://sourceforge.net/tracker/index.php?func=detail&aid=1355971&group_id=5470&atid=305470
msg26871 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2005-12-16 21:49
Logged In: YES user_id=1188172 Is that still an issue?
msg26872 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2006-04-14 15:04
Logged In: YES user_id=21627 This was fixed with patch #1355971.