Issue 1380777: Some fixes for the binary distribution builder (original) (raw)

Created on 2005-12-14 20:25 by ronaldoussoren, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg49196 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2005-12-14 20:25
The attached patch fixes some problems with the build script for binary distributions on Mac OS X 1) the builder used to unconditionally replace parts of Apple's python installation. This is needed on OSX 10.3, but not on later versions. 2) corrects version numbers in several places, and verifies the correct version in the build script 3) the builddocs script usually crashes on my system after correctly building the documentation, workaround this in the build script 4) Some hacks w.r.t. a pyconfig.h file that works on 10.3 and 10.4 (see below) There is a problem with pyconfig.h in a binary distribution on OSX: there are some header file regressions between 10.3 and 10.4. This means that you cannot build extensions with a python that was build on 10.3 while running on 10.4 (unless you're lucky). My first workaround was a pyconfig.h that #include-d pyconfig-10.3.h or pyconfig-10.4.h after testing the current platform (by misusing some feature macros in AvailabilityMacros.h). This doesn't work because distutils reads pyconfig.h and makes that available to setup.py authors. A second, untested approach is to merge the two pyconfig.h files. I guess it would be good enough to just surpress the #defines for _POSIX_SOURCE, _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED on Tiger.
msg49197 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2005-12-14 20:55
Logged In: YES user_id=580910 I'm currently testing the obvious (in hindsight) solution for my pyconfig.h problems: $ diff -u Python-2.4.2-orig/configure.in Python-2.4.2/configure.in --- Python-2.4.2-orig/configure.in Sun Aug 7 23:08:53 2005 +++ Python-2.4.2/configure.in Wed Dec 14 21:41:32 2005 @@ -173,7 +173,7 @@ ;; # On Mac OS X 10.4, defining _POSIX_C_SOURCE or _XOPEN_SOURCE # disables platform specific features beyond repair. - Darwin/8.*) + Darwin/8.*|Darwin/7.*) define_xopen_source=no ;; That is, tell configure not to bother trying _POSIX_SOURCE on Darwin 7.x (aka Panther). So far this doesn't seem to cause regressions, but I haven't run the tests yet nor did I perform a full comparison between this build and a build without the patch above.
msg49198 - (view)	Author: Neal Norwitz (nnorwitz) *	Date: 2006-03-20 04:13
Logged In: YES user_id=33168 Ronald, this patch looks out of date due to your patch #1416559. If that's true, please close this patch.
msg49199 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2006-03-20 08:18
Logged In: YES user_id=580910 This patch is still valid, but applying it would be a waste of time: I want to replace the entire build script by something better. I have a better script as part of the python24-fat tree, I'm going to make some time to merge that tree.