Issue 1388073: Make unittest.TestCase easier to subclass (original) (raw)

Issue1388073

Created on 2005-12-22 14:56 by collinwinter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
unittest.py.patch	collinwinter,2005-12-22 14:56	Patch against unittest.py, r41775
before.py	collinwinter,2005-12-22 14:57	My subclass, before the patch to unittest.TestCase
after.py	collinwinter,2005-12-22 14:57	My subclass, after the patch to unittest.TestCase

Messages (3)
msg49214 - (view)	Author: Collin Winter (collinwinter) *	Date: 2005-12-22 14:56
While working on a subclass of unittest.TestCase to support TODO-tests, I found a large number of __-prefixed attributes in TestCase. The presence of these attributes (and methods) meant that I had to copy them over to my new subclass to make python happy. The attached patch converts these __-prefixed attributes to _-prefixed attributes, making it much simpler to subclass TestCase. The patch is against unittest.py from SVN revision 41775. Also attached are "before" and "after" versions of my subclass showing the impact of the patch.
msg49215 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2005-12-31 00:50
Logged In: YES user_id=6380 While I haven't reviewed the code, I am +1 on the intent of the patch. Subclassing TestCase (and other unittest classes!) is often a pain due to too much abstraction. (In retrospect, unittest.py is really way too close a translation of the Java junit package. Too bad.)
msg49216 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-01-20 17:55
Logged In: YES user_id=1188172 Patch looks good and does no harm. Committed revisions 42115, 42116 (2.4).