Issue 1434038: Make property use the getter's doc if no doc argument (original) (raw)

Created on 2006-02-18 08:37 by georg.brandl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (8)
msg49532 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-02-18 08:37
As requested by Guido in http://mail.python.org/pipermail/python-dev/2006-February/061320.html. The patch adds a check that fget, fset and fdel are callable, if present. Please check for ref leaks et al.
msg49533 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-02-18 09:51
Logged In: YES user_id=1188172 Adding docs and test suite changes.
msg49534 - (view)	Author: Alex Martelli (aleax) *	Date: 2006-02-18 15:21
Logged In: YES user_id=60314 in property-get-doc.diff: if doc is None and fget.__doc__ is not None: would raise a confusing TypeError when doc is fget is None -- check for that case explicitly to raise a specific exception. Also, property(fset=foo) used to work and thus must keep working. Similarly, the C code if ((get_doc = PyObject_GetAttrString(get, "__doc__"))) must reset the errorstate if get_doc is NULL. in property-get-doc-2.diff: Add unittest to check that property(fset=somecallable) keeps working. Alex
msg49535 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-02-18 18:51
Logged In: YES user_id=1188172 Thanks for the review. Attaching new patches with your corrections. I also added a DECREF which I think is necessary.
msg49536 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2006-02-19 20:08
Logged In: YES user_id=6380 I'll try to review this ASAP.
msg49537 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-03-08 17:32
Logged In: YES user_id=849994 Ping!
msg49538 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2006-03-08 17:47
Logged In: YES user_id=6380 Sorry, I really don't like the callable checks. IMO they're for wimps. You should be testing your code anyway, and then bad property args will show up the first time they are called. Without those, I'm fine with the changes. Discuss on python-def if you disagree.
msg49539 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-03-08 18:10
Logged In: YES user_id=849994 Fine with me too. Committed patch without callable checks as revision 42916.