Issue 1462488: Patch for bug #931877 Segfault in object_reduce_ex (original) (raw)

Created on 2006-04-01 00:30 by zseil, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg49916 - (view)	Author: Ziga Seilnacht (zseil) *	Date: 2006-04-01 00:30
This prevents unbounded recursion in typeobject.c's object_reduce_ex(). It does so by splitting implementation for object.__reduce_ex__ and object.__reduce__ into two different C functions. See the apended file details.txt for more detailed explanation.
msg49917 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2007-03-13 20:17
I think this patch is fine, but you should include at least some of the detailed description as a comment for the new reduce method.
msg49918 - (view)	Author: Ziga Seilnacht (zseil) *	Date: 2007-03-14 16:52
I would like to backport this patch to the 2.5 branch so I made a new wersion that is fully backwards compatible (well, except for the segfault :). Georg, could you please take another look? And thanks for all the reviews, I can hardly keep up :). File Added: typeobject_reduce_2.diff
msg49919 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2007-03-14 23:08
Looks good to me -- as you say, there shouldn't be any behavioral differences.
msg49920 - (view)	Author: Ziga Seilnacht (zseil) *	Date: 2007-03-15 11:51
Commited as revision 54397, 54398 (2.5).