Issue 1475845: IndentationError for unexpected indent (original) (raw)

Issue1475845

Created on 2006-04-24 23:12 by rcmiller, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg50106 - (view)	Author: Roger Miller (rcmiller)	Date: 2006-04-24 23:12
This patch raises an IndentationError rather than a generic "invalid syntax" error for unexpected indentation. Code to do this was already in pythonrun.c:err_input() but was not being reached due to a failure to pass the INDENT token in the perrdetail structure. The patch also adds tests for the 3 kinds of indentation errors (unexpected indent, no indent where required, invalid outdent level) to test_syntax.py .
msg50107 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2006-04-30 11:20
Logged In: YES user_id=849994 Martin, do we want to change this? I myself have always wondered what IndentationError was for if it was not raised in these cases.
msg50108 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2006-05-04 05:51
Logged In: YES user_id=21627 IndentationError is already raised for bad indentation, e.g. for "def f():\nreturn" or if 1:\nfoo()" (which is the test_no_indent) However, the patch is right in filling the token in this case, also; I accepted it as r45897. As it changes the exceptio behaviour, I don't think it should be backported.