Issue 1488943: difflib.Differ() doesn't always add hints for tab characters (original) (raw)

Created on 2006-05-15 16:27 by henryl, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test.patch henryl,2006-05-16 13:19 Patch to lib/test/test_difflib.py
difflib_fix.patch henryl,2006-05-16 13:21 Fix tab hinting for difflib.Differ
Messages (8)
msg28539 - (view) Author: Henry (henryl) Date: 2006-05-15 16:27
The difflib.Differ() object doesn't always add a hint for added tab characters. eg: import difflib differ = difflib.Differ() for change in differ.compare(["\tI am a buggy"], ["\t\tI am a bug"]): print repr(change) Should return '- \tI am a buggy' '? \t --\n' '+ \t\tI am a bug' '? +\n' but actually returns (no hint for the added tab) '- \tI am a buggy' '? \t --\n' '+ \t\tI am a bug' sys.version reports 2.4.1 (#65, Mar 30 2005, 09:13:57) [MSC v.1310 32 bit (Intel)]
msg28540 - (view) Author: Henry (henryl) Date: 2006-05-16 13:18
Logged In: YES user_id=1083163 Patch to lib/test/test_difflib.py attached.
msg28541 - (view) Author: Henry (henryl) Date: 2006-05-16 13:19
Logged In: YES user_id=1083163 Try again (this time selecting check box)...
msg28542 - (view) Author: Henry (henryl) Date: 2006-05-16 13:21
Logged In: YES user_id=1083163 Fix attached. Note that this also modifies the doctest for Differ._qformat, as the doctest version actually exhibited the bug (the added tab character wasn't hinted).
msg95466 - (view) Author: Phillip Hellewell (sshock) Date: 2009-11-19 08:31
Please apply the patch ASAP. This bug is affecting downstream product viewvc in a very adverse way. See http://viewvc.tigris.org/issues/show_bug.cgi?id=436 It's sad that I spent several hours tracking down this bug only to find out that henryl found it and provided a fix *3 and a half years ago*. Why is it taking so long to apply such a small yet important patch?
msg95642 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-11-23 18:42
Yes, I noticed the issue and found the patch to be good as well. Unfortunate it was pending for a long time. Fixed and Committed revision 76464 (trunk).
msg95645 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-11-23 18:56
merged to 26-maint in revision 76468 and shall merge in py3k too.
msg95646 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2009-11-23 19:07
fixed r76469 (py3k) and r76470(release31-maint). Closing the issue.
History
Date User Action Args
2022-04-11 14:56:17 admin set github: 43363
2009-11-23 19:07:06 orsenthil set status: open -> closedmessages: +
2009-11-23 18:56:29 orsenthil set messages: +
2009-11-23 18:42:32 orsenthil set nosy: + orsenthilmessages: + assignee: orsenthilresolution: fixed
2009-11-19 08:31:53 sshock set nosy: + sshockmessages: +
2009-03-21 02:45:38 ajaksu2 set keywords: + patchstage: patch reviewtype: behaviorversions: + Python 2.6, Python 3.0, - Python 2.4
2006-05-15 16:27:37 henryl create