From SVN, longobject.c gives the following compiler warnings (Sun Studio 11): cc -xtarget=native64 -v -Xc -xc99=none -c -DNDEBUG -O -I. -I./Include -DPy_BUILD_CORE -o Objects/longobject.oObjects/longobject.c "Objects/longobject.c", line 1255: warning: statement not reached "Objects/longobject.c", line 1591: warning: statement not reached "Objects/longobject.c", line 1908: warning: statement not reached "Objects/longobject.c", line 1946: warning: statement not reached The attached patch fixes the problem.
Logged In: YES user_id=31435 Thanks for the patch! I don't see an actual problem with the code as it was, and expect the compiler warnings are bogus. But your patch shouldn't hurt either, and makes the intent of the macro clearer to my eyes, so I applied it to the trunk (for Python 2.5).