Issue 1517891: Bug 1514451: zipfile "append" mode should create a file ... (original) (raw)

Issue1517891

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	Bug 1514451: zipfile "append" mode should create a file ...
Type:	Stage:
Components:	Library (Lib)	Versions:	Python 2.5

process

Status:	closed	Resolution:	accepted
Dependencies:		Superseder:
Assigned To:		Nosy List:	krumms, loewis, ronaldoussoren
Priority:	normal	Keywords:	patch

Created on 2006-07-06 02:25 by krumms, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
zipfile_create_on_append.patch	krumms,2006-07-06 02:25	zipfile.ZipFile('...', 'a') will now create the named file if it does not already exist

Messages (4)
msg50617 - (view)	Author: Thomas Lee (krumms)	Date: 2006-07-06 02:25
'[ 1514451 ] zipfile "append" mode should create a file if not present' I thought this was a logical suggestion. Here's a patch, including tests.
msg50618 - (view)	Author: Thomas Lee (krumms)	Date: 2006-07-06 02:28
Logged In: YES user_id=315535 It should be noted that the decision not to modify self.mode (i.e. change it to 'w', which is effectively what we're doing) was a conscious decision: existing code may depend on the mode attribute (however unlikely that might be).
msg50619 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2006-07-06 08:42
Logged In: YES user_id=580910 This patch looks sane. What I don't know is if this qualifies as a bugfix or if this is a new feature (however minor).
msg50620 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2007-02-13 10:11
I think there is a documentation patch missing, also: the documentation explicitly mentions that mode 'a' means to append to an existing file. I changed the documentation accordingly, and committed the patch as r53766. Thanks for the contribution!