Issue 1520904: Fix tests that assume they can write to Lib/test (original) (raw)

Created on 2006-07-12 00:53 by dgreiman, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
readonly_tests_fix.diff dgreiman,2006-07-12 00:53 Patch to Lib/bsddb/test/* and Lib/test_tarfile.py (r50594)
Messages (6)
msg50666 - (view) Author: Douglas Greiman (dgreiman) * Date: 2006-07-12 00:53
A number of bsddb tests, as well as test_tarfile, create temporary files in Lib/ or {prefix}/lib/pythonX.Y/ . This change uses tempfile.gettempdir() instead. Tested on RedHat 9.0 Linux on x86.
msg50667 - (view) Author: Matt Fleming (splitscreen) Date: 2006-08-31 11:07
Logged In: YES user_id=1126061 This looks fine to me, and a worthwhile change.
msg50668 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2007-01-05 15:14
Can you clarify in what cases test_tarfile writes to the current directory?
msg50669 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2007-01-05 15:52
Committed the Lib/bsddb changes to the trunk in rev. 53264; thanks! That leaves only the tarfile change to commit, but I'd like to understand why it's necessary first.
msg50670 - (view) Author: Björn Lindqvist (sonderblade) Date: 2007-06-06 16:03
I think the submitter is referring to the ./Lib/test/testtar.tar file, which one could guess is created when you run test_tarfile.py. But that file is distributed with Python and AFAICT, test_tarfile.py doesn't create temporary files in bad directories. So I think it is safe to close this patch.
msg50671 - (view) Author: Douglas Greiman (dgreiman) * Date: 2007-06-07 03:03
test_tarfile.py was independently fixed by rev 54335. Closing as fixed.
History
Date User Action Args
2022-04-11 14:56:18 admin set github: 43654
2006-07-12 00:53:07 dgreiman create