Issue 1534084: Fix code generation bug in 'compiler' package (original) (raw)

Issue1534084

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	Fix code generation bug in 'compiler' package
Type:	Stage:
Components:	Library (Lib)	Versions:

process

Status:	closed	Resolution:	accepted
Dependencies:		Superseder:
Assigned To:	nascheme	Nosy List:	nascheme, nnorwitz
Priority:	critical	Keywords:	patch

Created on 2006-08-03 19:51 by nascheme, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
make_closure_fix.txt	nascheme,2006-08-03 19:51

Messages (4)
msg50829 - (view)	Author: Neil Schemenauer (nascheme) *	Date: 2006-08-03 19:51
The compiler package generates invalid code for nested functions (a BUILD_TUPLE opcode is now required). Obviously we need better tests for the package. It would be really nice if this could get fixed before 2.5 is released.
msg50830 - (view)	Author: Neal Norwitz (nnorwitz) *	Date: 2006-08-04 03:53
Logged In: YES user_id=33168 Good catch! It's always good to see bug fixes which remove code. :-) Please checkin once the the code is unfrozen. It would be good to mention this patch # in the NEWS entry. This is also a backport candidate, isn't it?
msg50831 - (view)	Author: Neil Schemenauer (nascheme) *	Date: 2006-08-04 05:57
Logged In: YES user_id=35752 No, it's not a backport candidate. During the 2.5 development cycle I changed the way the MAKE_CLOSURE opcode worked.
msg50832 - (view)	Author: Neil Schemenauer (nascheme) *	Date: 2006-08-04 16:20
Logged In: YES user_id=35752 Committed as revision 51109.