Issue 1603424: subprocess.py (py2.5) wrongly claims py2.2 compatibility (original) (raw)

From the comments in subprocess.py (py2.5):

This module should remain compatible with Python 2.2, see PEP 291.

However, using it from Python 2.2 gives: NameError: global name 'set' is not defined

(set built-in used on line 1005)

The subprocess.py in py2.4 was 2.2 compatible.

Either the compatibility comment should be removed/amended or compatibility fixed.

Index: subprocess.py

--- subprocess.py (revision 52918) +++ subprocess.py (working copy) @@ -1004,8 +1004,8 @@

                 # Close pipe fds.  Make sure we don't close the same
                 # fd more than once, or standard fds.

•                for fd in set((p2cread, c2pwrite, errwrite))-set((0,1,2)):

•                    if fd: os.close(fd)

•                for fd in (p2cread,c2pwrite,errwrite):

•                    if fd not in (0,1,2): os.close(fd)
  
                 # Close all other fds, if asked for
                 if close_fds:

Fixed?