Issue 1654417: operator.c slice functions need to parse ssize_t (original) (raw)

Created on 2007-02-07 17:58 by wingo, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
operator_slice.diff wingo,2007-03-06 16:15 updated patch to parse ssize_t, not int, tests from zseil
Messages (5)
msg51844 - (view) Author: Andy Wingo (wingo) Date: 2007-02-07 17:58
To reproduce, on a system with 64 bits in sys.maxint: $ python x = [3,4,5] del x[1:] x = [3,4,5] from operator import delslice import sys delslice(x, 1, sys.maxint) Traceback (most recent call last): File "", line 1, in OverflowError: signed integer is greater than maximum
msg51845 - (view) Author: Ziga Seilnacht (zseil) * (Python committer) Date: 2007-03-06 16:04
The patch looks correct to me, but I can't test it since I don't have a 64 bit system. I posted the patch with added tests here: http://freeweb.siol.net/chollus/ Can someone with the right privileges attach that file here?
msg51846 - (view) Author: Andy Wingo (wingo) Date: 2007-03-06 16:15
File Added: operator_slice.diff
msg51847 - (view) Author: Andy Wingo (wingo) Date: 2007-03-06 16:15
Updated the patch, thanks for the tests, zseil.
msg51848 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2007-03-06 19:00
Committed as rev. 54177, 54178 (2.5).
History
Date User Action Args
2022-04-11 14:56:22 admin set github: 44558
2007-02-07 17:58:48 wingo create