This issue has been migrated to GitHub: https://github.com/python/cpython/issues/44659
classification
process
Created on 2007-03-05 02:45 by eric.smith, last changed 2022-04-11 14:56 by admin. This issue is now closed.
Files |
|
|
|
File name |
Uploaded |
Description |
Edit |
1673757-1.diff |
eric.smith,2007-03-10 18:57 |
Updated for 79 char line limit. |
|
Messages (9) |
|
|
msg52052 - (view) |
Author: Eric V. Smith (eric.smith) *  |
Date: 2007-03-05 02:45 |
See http://python.org/sf/1673757 |
|
|
msg52053 - (view) |
Author: Eric V. Smith (eric.smith) *  |
Date: 2007-03-06 11:10 |
Updated diff file attached, with correct filenames and with updated tests. File Added: 1673757.diff |
|
|
msg52054 - (view) |
Author: Paul Hankin (paulhankin) |
Date: 2007-03-10 18:01 |
Your change in Objects/stringobject.c and Objects/unicodeobject.c goes over the 79 character line limit. Otherwise looks ok - compiles, runs, tests look correct and pass. |
|
|
msg52055 - (view) |
Author: Eric V. Smith (eric.smith) *  |
Date: 2007-03-10 18:57 |
Thanks for the catch on the line length. I've updated the patch and attached it. File Added: 1673757-1.diff |
|
|
msg52056 - (view) |
Author: Eric V. Smith (eric.smith) *  |
Date: 2007-03-10 18:58 |
Improved summary. |
|
|
msg52057 - (view) |
Author: Paul Hankin (paulhankin) |
Date: 2007-03-10 21:50 |
lgtm |
|
|
msg52058 - (view) |
Author: Guido van Rossum (gvanrossum) *  |
Date: 2007-03-18 03:57 |
Changing the category to 2.5; since the bug appears in 2.5 and 2.6, this should be applied to 2.5 and to the trunk (i.e. 2.6) and then it will automatically be merged into 3.0 when the next merge is done. |
|
|
msg52059 - (view) |
Author: Björn Lindqvist (sonderblade) |
Date: 2007-06-04 23:11 |
Shouldn't this be committed now? |
|
|
msg52060 - (view) |
Author: Georg Brandl (georg.brandl) *  |
Date: 2007-07-12 08:39 |
Committed in rev. 56298, 56299 (2.5). |
|
|
History |
|
|
|
Date |
User |
Action |
Args |
2022-04-11 14:56:22 |
admin |
set |
github: 44659 |
2007-03-05 02:45:59 |
eric.smith |
create |
|