Issue 1675981: Remove dead code in typeobject's type_new() (original) (raw)
Issue1675981
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/44679
classification
| Title: | Remove dead code in typeobject's type_new() | ||
|---|---|---|---|
| Type: | Stage: | ||
| Components: | Interpreter Core | Versions: | Python 2.5 |
process
| Status: | closed | Resolution: | accepted |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | zseil | Nosy List: | loewis, zseil |
| Priority: | normal | Keywords: | patch |
Created on 2007-03-07 18:34 by zseil, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| type_new_dead_code.diff | zseil,2007-03-07 18:34 | patch against trunk revision 54179 |
| Messages (3) | ||
|---|---|---|
| msg52098 - (view) | Author: Ziga Seilnacht (zseil) *  |
Date: 2007-03-07 18:34 |
| The code that this patch removes can never be reached; __dict__ and __weakref__ are removed from the slots tuple earlier in the code, in the loop that mangles slot names, around line 1850. I think that this code was just overlooked in the last refactoring, in revision 28166. | ||
| msg52099 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2007-03-10 11:57 |
| This looks fine, please apply. | ||
| msg52100 - (view) | Author: Ziga Seilnacht (zseil) * |
Date: 2007-03-11 16:05 |
| Commited as revision 54270, 54272 (2.5). |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:23 | admin | set | github: 44679 |
| 2007-03-07 18:34:08 | zseil | create |