Issue 1676994: Refactor test_popen2.py to use unittest. (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/44687

classification

process

Created on 2007-03-09 06:38 by jerry.seutter, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg52136 - (view)	Author: Jerry Seutter (jerry.seutter) *	Date: 2007-03-09 06:38
This patch turns test_popen2.py into a unittest file. There should be no changes in what the file tests. Modifying test_popen2.py to use unittest also required making a small change to popen2.py, which also contains some testing code. Lib/test/output/test_popen2 should be removed when this patch is applied.
msg52137 - (view)	Author: Collin Winter (collinwinter) *	Date: 2007-03-16 02:46
Why not fold popen2._test() into test_popen2? Is there a reason for the "verbose = False" assignment at the top?
msg52138 - (view)	Author: Jerry Seutter (jerry.seutter) *	Date: 2007-03-16 04:51
File Added: refactor_test_popen2.py.patch
msg52139 - (view)	Author: Jerry Seutter (jerry.seutter) *	Date: 2007-03-16 04:53
patch v2 changes: verbose = False was a bug. Removed. Folded popen2._test() moved into test_popen2 (good idea, btw). Refactored some more.
msg52140 - (view)	Author: Collin Winter (collinwinter) *	Date: 2007-03-16 21:16
Checked in as r54417. Thanks for the patch!