Issue 1677694: test_timeout refactoring - Python tracker (original) (raw)

Created on 2007-03-10 00:49 by sonderblade, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg52144 - (view)	Author: Björn Lindqvist (sonderblade)	Date: 2007-03-10 00:49
Please see #728815. https://sourceforge.net/tracker/index.php?func=detail&aid=728815&group_id=5470&atid=305470
msg52145 - (view)	Author: Collin Winter (collinwinter) *	Date: 2007-03-10 03:39
In a comment on patch #728815, you (Bjorn) said, "[p]lus, (I think) it fixes a bug which (I think) only happens when you access the internet from behind a web proxy." Could you split any bug fixes into a patch separate from the code cleanup and refactoring? That will make reviewing it/them easier.
msg52146 - (view)	Author: Björn Lindqvist (sonderblade)	Date: 2007-03-10 14:39
But the bugfix is so simple. :) The original author Dmitry Vasiliev claimed that connecting to www.google.com with port 80 did not always work for him because of a transparent proxy. I believe what he meant was that connection was not guaranteed to timeout. So he changed the port to 21 which www.google.com does not respond to.
msg110531 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2010-07-17 00:05
The patch is purely a change to unit test code involving sockets, anyone with experience of these who could review the patch?
msg116626 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2010-09-16 22:06
Could someone with commit privileges please take this forward?
msg125528 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2011-01-06 09:06
I adapted the patch for current py3k and committed it in r87786. Thank you for your patience.