The attached file contains a patch to: - remove the "just import it" test for pipes from test_sundry.py - add test_pipes to expected skips on win32 in regrtest.py - remove the "small test program and example" from pipes.py (it seems to me this is best put in either tests or docs instead of the module itself) It also includes a new test_pipes.py module. At the moment this covers about 86% of the pipes.py code; I'll try to get that higher, but I wanted to throw this out there for initial feedback.
Thanks for your patch! Initial comments: * test_pipes does not conform to PEP 8 (whitespace issues, line length, etc). * SVN reports that test_pipes has inconsistent line endings. * Calling os.path.exists() as a check before os.unlink() creates a race condition; just catch the exception. * In the future, please include new files in the patch itself. "svn add" the file, then "svn diff" will include it when creating the diff. Please address these issues.
I adjusted things to conform to PEP 8 (I hope), changed the exists/unlink as suggested, ran reindent.py on test_pipes.py, and included test_pipes.py in the patch. File Added: pipes-tests-2.diff
