Issue 1714451: subprocess.py problems errors when calling cmd.exe (original) (raw)

Issue1714451

Created on 2007-05-07 17:13 by tzellman, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (7)
msg31976 - (view)	Author: tzellman (tzellman)	Date: 2007-05-07 17:13
An example: >>> import subprocess >>> proc = subprocess.Popen('"c:\Windows\system\ping.exe" "localhost"', shell=1, stdout=subprocess.PIPE, stderr=subprocess.PIPE) 'c:\Windows\system32\ping.exe" "localhost' is not recognized as an internal or external command, operable program or batch file. This normally works from the cmd.exe prompt, so the command line is being passed incorrectly in the subprocess module. My ACTUAL use case arises when I want to call the Microsoft compiler (CL.exe), and add include directories that have spaces in the name. For example: "C:\Program Files\Microsoft Visual Studio 8\VC\BIN\CL.exe" /TC /O2 /DNDEBUG /W3 /nologo /c /EHsc /errorReport:prompt /Idefault\ /I.. /I. /Idefault /I"C:\Program Files\GnuWin32" /DWIN32 ..\pcreposix.c /Fodefault\pcreposix.obj The fix for this problem is to modify line 765 in subprocess.py, replacing it with: args = comspec + " /s /c \"%s\"" % args.replace('""', '"') The /s tells cmd.exe not to re-format the command line. We then encase the entire command line in double quotes. I also replace occurrences of "" with " in the arg string, in case the user already encased the command in double quotes. With this fix, the commands execute correctly.
msg31977 - (view)	Author: tzellman (tzellman)	Date: 2007-05-07 17:20
This could likely be rejected. I realize a solution to this w/o modifying the Python source is to encase the expression yourself in double quotes. So, the example given would look like: >>> import subprocess >>> proc = subprocess.Popen('""c:\Windows\system\ping.exe" "localhost""', shell=1, stdout=subprocess.PIPE, stderr=subprocess.PIPE) And that will work. Sorry for any confusion.
msg31978 - (view)	Author: Gabriel Genellina (ggenellina)	Date: 2007-05-07 21:06
Use a list of arguments instead, and please remember to use raw strings or double backslashes: proc = subprocess.Popen([r"c:\Windows\system\ping.exe","localhost"], shell=1, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
msg31979 - (view)	Author: Collin Winter (collinwinter) *	Date: 2007-06-05 18:36
tzellman, could you work up a real patch and a test case for this? Thanks.
msg84722 - (view)	Author: Daniel Diniz (ajaksu2) *	Date: 2009-03-30 23:54
Collin: do you still want a patch or is this a won't fix?
msg84749 - (view)	Author: Collin Winter (collinwinter) *	Date: 2009-03-31 04:04
Do you know of anyone actively working on Windows support? If not, I say close it as "won't fix".
msg113281 - (view)	Author: Tim Golden (tim.golden) *	Date: 2010-08-08 16:42
Duplicate of #2304