Issue 522274: compiler/transformer.py STARSTAR doesn't exist (original) (raw)

Created on 2002-02-25 01:40 by efm, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Messages (5)
msg9388 - (view)	Author: Evelyn Mitchell (efm)	Date: 2002-02-25 01:40
pyChecker complains at line 774 of tokenizer.py No module attribute (STARSTAR) found The section is: if i < len(nodelist): # should be DOUBLESTAR or STAR STAR t = nodelist[i][0] if t == token.DOUBLESTAR: node = nodelist[i+1] elif t == token.STARSTAR: node = nodelist[i+2] else: raise ValueError, "unexpected token: %s" % t names.append(node[1]) flags = flags | CO_VARKEYWORDS I've verified that there is no STARSTAR in token.py. I'd patch this to be token.STAR, which does exist, but this module has no self tests or unit tests, so I wouldn't be able to know if it broke anything. My wild guess is that the intention is to refer to two STAR tokens rather than a DOUBLESTAR token (and that is because the increment is 2 rather than 1), but I think that evidence is pretty slim.
msg9389 - (view)	Author: Just van Rossum (jvr) *	Date: 2002-03-10 18:48
Logged In: YES user_id=92689 I don't see a file "tokenizer.py" in the repository, only "tokenize.py", which only has 262 lines. What is this bug about?
msg9390 - (view)	Author: Evelyn Mitchell (efm)	Date: 2002-03-16 16:18
Logged In: YES user_id=13263 Sorry, too much caffine. The file is compiler/transformer.py
msg9391 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2002-03-16 19:21
Logged In: YES user_id=6380 I think the STARSTAR should be STAR. Jeremy, can you confirm & fix? Also, there needs to be a unittest for this code, apparently!
msg9392 - (view)	Author: Jeremy Hylton (jhylton)	Date: 2002-04-19 22:59
Logged In: YES user_id=31392 Fixed in rev 1.33 of transformer.py and in rev 1.80.8.1.2.1 (release22-maint branch). Not present in earlier versions.