| msg39708 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-26 15:24 |
| RFC 2231 defines the methods for encoding and decoding parameters in mail headers. This patch adds support for parameter decoding. It changes the interface of Message._get_params_preserve() - the function can return not only an ASCII string, but also 3-tuple (charset, language, value). Utils.py contains low-level functions. All users of _get_params_preserve() changed, too - get_params(), get_param(). Message.get_filename() returns either ASCII or Unicode string. |
|
|
| msg39709 - (view) |
Author: Martin v. Löwis (loewis) *  |
Date: 2002-04-26 19:58 |
| Logged In: YES user_id=21627 Did you test this code with non-ASCII messages? I discourage the use of the default encoding. Instead, if an encoding is present, a Unicode object, or the information about the original encoding should be returned. If absolutely necessary, conversion to the default encoding is acceptable if UnicodeError is caught for the encoding to the default encoding. I'm not sure how to deal with UnicodeErrors when constructing the Unicode object: you probably should create an exception, but have that exception carry the data that you caused the problem, so that the caller has the opportunity to process them by other means. |
|
|
| msg39710 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-29 10:40 |
| Logged In: YES user_id=4799 > Did you test this code with non-ASCII messages? I did. > I discourage the use of the default encoding. What is the "default encoding" in this context? |
|
|
| msg39711 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-29 10:40 |
| Logged In: YES user_id=4799 > Did you test this code with non-ASCII messages? I did. > I discourage the use of the default encoding. What is the "default encoding" in this context? |
|
|
| msg39712 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2002-04-29 11:34 |
| Logged In: YES user_id=21627 The default encoding is the one returned by sys.getdefaultencoding(). If this returns, on your system, say, 'koi-8r', then testing the patch with koi-8r is equivalent to testing it with ASCII only in a standard installation. In your patch, the line value = unicode(value[2], value[0]).encode() makes use of the default encoding in the .encode call; this call should always have an argument - it will fail if value[0] differs from the default encoding, and characters from the set difference between the encodings are used in value[2]. |
|
|
| msg39713 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-29 11:50 |
| Logged In: YES user_id=4799 > I discourage the use of the default encoding. Instead, if an encoding is present, a Unicode object, or the information about the original encoding should be returned. This particular function (_formatparam) must return an ASCII string, not an Unicode object. The resulting string is put into a header. |
|
|
| msg39714 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2002-04-29 11:58 |
| Logged In: YES user_id=21627 If it really *has* to be ASCII, please be explicit about this, invoking .encode('ascii'). I still wonder whether this could raise a UnicodeError, though. Another comment: 'languge' is spelled incorrectly in a few places. |
|
|
| msg39715 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-29 12:24 |
| Logged In: YES user_id=4799 > .encode('ascii') Agree. > languge Fixed. |
|
|
| msg39716 - (view) |
Author: Oleg Broytman (phd) * |
Date: 2002-04-29 12:26 |
| Logged In: YES user_id=4799 New patch uploaded. |
|
|
| msg39717 - (view) |
Author: Barry A. Warsaw (barry) * |
Date: 2002-06-29 05:50 |
| Logged In: YES user_id=12800 Thanks Oleg! Sorry for the delay. I've accepted this patch and backported it to Python 2.1 (which the email package must still support). Will commit it to Python 2.3 cvs momentarily. |
|
|