| msg41382 - (view) |
Author: Art Haas (ahaas) |
Date: 2002-10-15 21:30 |
| Hi. Here's a small patch that adjust AC_INIT and AC_OUTPUT from the autoconf-2.13 style to the new autoconf-2.5X style. In changing these macros to their new format, the addition of AC_CONFIG_SRCDIR and AC_CONFIG_FILES is required. I've also removed the VERSION macro as that value can be defined in the second argument of AC_INIT. Art Haas ahaas@neosoft.com |
|
|
| msg41383 - (view) |
Author: Martin v. Löwis (loewis) *  |
Date: 2002-10-16 11:22 |
| Logged In: YES user_id=21627 It appears that you did not test this change. AC_INIT does not define VERSION, but PACKAGE_VERSION. Even if this is fixed (somehow), the resulting pyconfig.h will be installed, and then conflict in its PACKAGE_VERSION definition with other packages which also use autoconf. So I'm not sure this should be done at all. |
|
|
| msg41384 - (view) |
Author: Art Haas (ahaas) |
Date: 2002-10-16 16:44 |
| Logged In: YES user_id=629911 Hi. I did test this, and it worked fine - as far as I could tell. The autoconf docs I have (autoconf-2.54) show that AC_INIT is defined like ... AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME]) ... and PACKAGE_VERSION is taken from VERSION. I suppose that if there is a conflict, then the variable VERSION can be directly defined after AC_INIT, and it can be specified to whatever is needed to avoid the problems you see. Still, the format for the AC_INIT macro as it exists now is obsolete, so I believe it's better to change to the current format. Changing AC_OUTPUT to the current style is also a good move IMHO. There's another change I'd also suggest - renaming configure.in to configure.ac, as autoconf now suggests the ".ac" extension. That can be done later. Art Haas |
|
|
| msg41385 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2002-10-16 19:32 |
| Logged In: YES user_id=21627 Can you please verify the setting of VERSION in your generate Makefile? When I use your patch, I get VERSION= whereas I should get VERSION= 2.3 Also, can you please use autoconf 2.53? This is the version that Python is currently is developed with, and we cannot make use of strategies or features that are available in 2.54 only. |
|
|
| msg41386 - (view) |
Author: Art Haas (ahaas) |
Date: 2002-10-17 15:55 |
| Logged In: YES user_id=629911 My Makefile has a blank VERSION also, so I see that the part of the patch where I removed the VERSION variable is wrong. I'm attaching a new patch for the AC_INIT bits of configure.in. In this patch, there are a couple of variables defined using m4_define(), and these are then used to provide the version argument for AC_INIT and the value for the VERSION variable. After rebuilding configure with this patch, the variable VERSION in the Makefile is set to 2.3, as it should be. The AC_OUTPUT changes from the first patch are still good. |
|
|
| msg41387 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2002-10-26 13:49 |
| Logged In: YES user_id=21627 I have committed something like this as configure.in 1.360; configure 1.349; The version computation appeared to me overly complex, and I've omitted the bug report address: the info documentation says this should be an email address, not an URL. |
|
|