Issue 626548: Support Hangul Syllable names (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/37354

classification

Title: Support Hangul Syllable names
Type: Stage:
Components: None Versions:

process

Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: lemburg, loewis
Priority: normal Keywords: patch

Created on 2002-10-21 21:11 by loewis, last changed 2022-04-10 16:05 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
hangul.txt loewis,2002-10-22 06:10
hangul.txt loewis,2002-11-11 14:45
Messages (9)
msg41420 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-21 21:11
This patch implements section 25.2 of ISO 10646 (Character names and annotations for Hangul syllables).
msg41421 - (view) Author: Marc-Andre Lemburg (lemburg) * (Python committer) Date: 2002-10-23 10:32
Logged In: YES user_id=38388 One more minor nit: the indentation in the C file is 4 chars, please reindent your code accordingly.
msg41422 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-23 10:42
Logged In: YES user_id=21627 Perhaps the entire file should be formatted to conform with PEP 7 (single-tab indents, where a tab is worth 8 spaces). Should I submit a separate patch for this reformatting?
msg41423 - (view) Author: Marc-Andre Lemburg (lemburg) * (Python committer) Date: 2002-10-23 11:00
Logged In: YES user_id=38388 No, I'd rather leave things as they are w/r to indentation. Thanks.
msg41424 - (view) Author: Marc-Andre Lemburg (lemburg) * (Python committer) Date: 2002-10-23 11:02
Logged In: YES user_id=38388 Apart from that the patch looks ok. Do you have some docs to go with it ?
msg41425 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-23 11:31
Logged In: YES user_id=21627 Can you please elaborate this position? Is it not important to follow the established and agreed style guide?
msg41426 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-10-23 11:41
Logged In: YES user_id=21627 As for docs: I'd add a NEWS entry only.
msg41427 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-11-11 14:45
Logged In: YES user_id=21627 I have now updated the patch to use 4-space indents, and added a NEWS entry. Any further changes needed?
msg41428 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2002-11-23 12:23
Logged In: YES user_id=21627 Since there were no further comments, committed as NEWS 1.537 unicodedata.c 2.21
History
Date User Action Args
2022-04-10 16:05:46 admin set github: 37354
2002-10-21 21:11:38 loewis create