Logged In: YES user_id=21627 The patch looks quite good, overall. However, I don't like the use of eval to generate the plural form function: it is, in general, a security issue to evaluate a string that you read from some file. I would prefer if it parses the string, or uses other mechanisms to establish "safety": for example, if the only identifier occurring in the string is 'n', then this would be a good test. You might want to use tokenize.generate_tokens for that.
Logged In: YES user_id=17532 I wasn't aware of the security implications, there will be a new version of the patch sometime between 18 and 30 this month. I used eval for simplicity and performance reasons, the lookup in the catalog must be as fast as posible, so the parsing must be when the MO file is loaded. I will keep the use of eval, but it will check that 'n' is the only identifier used and, by the way, I will clean this part of the patch.
Logged In: YES user_id=21627 Just in case the security implications are not clear: Somebody might put os.chmod('/etc/passwd',0777) into a message catalog, and the superuser might run that script.
