Issue 638673: Added Proxyauth command to imaplib (original) (raw)

Logged In: YES user_id=33168

Richard, thanks for the patch.

I have a couple of problems with the patch.

• The patch is against 2.2, not HEAD.
  In this case it's easy to see where it should go, but that isn't always the case.
• This patch contains tabs, all python code in the standard library should contain only spaces.
• In the code that was added, name is not used.
  Either name should be removed, or it should be passed to _simple_command().
• There is also no documentation (Doc/lib/libimap.tex).

I don't know if this patch is worthwhile, since I know nothing about imap. Someone else will have to determine if this proxyauth is generally applicable and should be included. However, are there any security issues associated with using proxyauth?