| msg42710 - (view) |
Author: Robin Dunn (robind) |
Date: 2003-02-06 21:07 |
| This patch adds the ability to specify that shared libraries and Frameworks (the last is untested as of yet) to the bundle. It is mostly by Kevin Olliver with some suggestions by me. In addition to copying the files into the bundle the launcher script in the bundle is modified to set the DYLD_LIBRARY_PATH to the right place. |
|
|
| msg42711 - (view) |
Author: Just van Rossum (jvr) *  |
Date: 2003-02-06 22:35 |
| Logged In: YES user_id=92689 Cool. There's a problem with the patch, though: although I apologize for using tabs to begin with, please keep the tab usage consistent. There are quite a few hunks in the patch that only touch whitespace and that's both undesirable as well as blurring the intent of the patch... Could you upload a cleaner one? Btw. for the --standalone build mode it would be possible to calculate all framework/dylib dependencies with the otool tool. If this were implemented perhaps the --lib option wouldn't even be needed? Another question remains: if we include a framework, is there a way to strip it from redunant files, eg. headers? If we would use this mechanism to include Python.framework we would definitely need a way to trim it down, eg. all of lib is taken care of by modulefinder anyway. If you (or Kevin) have any ideas about that, pls contact me off line. |
|
|
| msg42712 - (view) |
Author: Robin Dunn (robind) |
Date: 2003-02-06 23:20 |
| Logged In: YES user_id=53955 Oops, sorry for the witespace patches. I noticed that my lines used spaces but the lines around them were using tabs so I just ran a tabify on the whole file without taking another look at the resulting patch file after that. Looks like some of other lines that wre added since 2.3a1 have spaces too and that is where the problem comes from. I'll redo the patch but the whole file should probably be either tabified or untabified after you are done applying it. I didn't know about otool. I'll pass that on to Kevin. We discussed about doing automatic finding of libs but didn't know how to go about it so thought that this would be a good start. Also we figured that even if there was a way to do it that you would probably want a way to inlcude other files that may not get automatically found, or to exclude some that were, so there should be command line options for it anyway. |
|
|
| msg42713 - (view) |
Author: Just van Rossum (jvr) * |
Date: 2003-02-07 08:59 |
| Logged In: YES user_id=92689 I use tabs for indentation and use spaces for alignment... So things look nice _and_ wont screw up with different tab settings. But I admit that using such a non-standard way is asking for trouble. I'll convert to spaces after this patch has been done (unless you prefer I do it _before_ ;-). (Btw. it might be that otool is only available with the apple dev tools, which would be a shame since we otherwise don't depend in dev tools being available. Hm.) |
|
|
| msg42714 - (view) |
Author: Kevin Ollivier (kollivier) |
Date: 2003-02-07 20:52 |
| Logged In: YES user_id=248468 I'll take a look at otool and see if it does what we need. As Robin mentioned, I think giving both the manual and auto options is the best approach. I'll also check into the dependency on Apple's Dev Tools, but even if it is dependent we could just switch off auto-detection if users don't have it and spit out a warning. Another possible way to alleviate this problem may be to integrate with distutils. (i.e. make a 'buildbundle' option) That should at least allow us to find and include any libraries the developer linked against. |
|
|
| msg42715 - (view) |
Author: Just van Rossum (jvr) * |
Date: 2003-03-18 18:22 |
| Logged In: YES user_id=92689 Having a manual option is a fine start. But can any of you rework the patch so it doesn't mess with whitespace, and update it for current CVS? |
|
|
| msg42716 - (view) |
Author: Robin Dunn (robind) |
Date: 2003-03-21 02:47 |
| Logged In: YES user_id=53955 New patch attached |
|
|
| msg42717 - (view) |
Author: Just van Rossum (jvr) * |
Date: 2003-03-21 09:41 |
| Logged In: YES user_id=92689 Thanks Robin, this is perfect. It's in CVS. |
|
|