Free time at PyCon led to me writing a new test_urllib (happy, Raymond? =). Since I have no guarantee that there would be a net connection (and didn't want to use it without user permission since I view using the 'network' resource as using sockets and not the Net) I wrote all tests using temporary files. And do this found a bug, sort of. The docs and doc string for urlretrieve() says the second value from the returned tuple should be None when a local file is passed as an argument. Well, it wasn't; it was returning an rfc2822.Message object like it does for remote files. So I patched it to match the docs.
Logged In: YES user_id=357491 I just noticed that Skip uploaded test_urllibnet.py to test timeouts by connecting to python.org . Is it okay to write tests that connect to the Net when the `network' resourse is enabled? If so then I can add network tests to test_urllib.py . Oh, and the beginning of the 2nd paragraph for my summary should have read "And I did find a bug, sort of" and not the mess of broken grammar rules as I initially typed it in. =)
Logged In: YES user_id=357491 This is bloody wonderful. Not only is the uploaded test_urllib.py the tet_urllib currently in CVS (i.e., the old one), but I can't find my new version nor can I delete the bad version I have uploaded (why can't SF let the creator of a patch delete files?). At least my patch for urllib.py is still okay. Damn it, now I have to write test_urllib from scratch, *again*. At least I am getting version 2.0 done before 1.0 is even out the door <0.1 wink>.
Logged In: YES user_id=357491 I am going to delete this patch entirely since I can commit the new tests myself. As for the bug I found, I will wait until I have finished my tests before I submit a final patch to make any and all fixes to urllib.
