Issue 737999: minor codeop fixes (original) (raw)

Issue737999

Created on 2003-05-15 01:55 by pedronis, last changed 2022-04-10 16:08 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
patch22maint.diff pedronis,2003-05-15 01:55 patch for 22 maint branch
patch23.diff pedronis,2003-05-15 01:57 patch for 2.3
Pull Requests
URL Status Linked Edit
PR 3179 closed abenkovskii@gmail.com,2017-08-22 11:17
Messages (3)
msg43791 - (view) Author: Samuele Pedroni (pedronis) * (Python committer) Date: 2003-05-15 01:55
*) compile_command("",eval) -> None , previously raised syntax error about "pass" *) symbol must be eval or single, now raises ValueError accordingly as specified in the documentation patch both for 2.3 and 2.2 maint for codeop.py and test/test_codeop.py (beefed up) (for Jython at the moment we use the test suite of 2.2 maint, that's why this is relevant)
msg43792 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2003-05-16 12:00
Logged In: YES user_id=6656 Given that codeop has *never* lived up to its promise to raise ValueError on 'exec', perhaps the docs should be fixed rather than the code? (I don't understand the point of supporting anything but 'single', but...). Certainly this change *should not* be made on the 22-maint branch. Can you check in your tests to both branches and port Guido's codeop.py change? Fixing up the docs gets you extra points, I think :-)
msg43793 - (view) Author: Samuele Pedroni (pedronis) * (Python committer) Date: 2003-05-17 02:46
Logged In: YES user_id=61408 committed: test_codeop.py 1.6 test_codeop.py 1.3.12.1 (release22-maint) codeop.py 1.5.16.1 (release22-maint)
History
Date User Action Args
2022-04-10 16:08:46 admin set github: 38504
2017-08-22 11:17:17 abenkovskii@gmail.com set pull_requests: + <pull%5Frequest3217>
2003-05-15 01:55:27 pedronis create