Issue 850789: call com_set_lineno more often (original) (raw)

Issue850789

Created on 2003-11-28 15:55 by mwh, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
doubleplussetlineno.diff mwh,2003-11-28 15:55 patch #1
Messages (2)
msg44959 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2003-11-28 15:55
This patch makes Python/compile.c:com_node call com_set_lineno unconditionally, and removes all the other calls to the function, exploiting the fact that com_set_lineno is now a noop when unnecessary. I can't help feeling this is too easy. What have I missed? Resulting python passes make test, but that's not really news.
msg44960 - (view) Author: Michael Hudson (mwh) (Python committer) Date: 2003-12-15 12:38
Logged In: YES user_id=6656 I withdraw this patch. It breaks tracing & frame_set_lineno in complicated ways that will take real thought to fix. The more I think about it, the more I think the hypothetical 2.4 compiler should use a richer data structure than c_lnotab.
History
Date User Action Args
2022-04-11 14:56:01 admin set github: 39618
2003-11-28 15:55:42 mwh create