Issue 988504: urllib2.AbstractHTTPHandler broken - Python tracker (original) (raw)

urllib2.AbstractHTTPHandler lost half of a change that went in with patch 852995 in 1.57. The attached patch fixes it again.

Jeremy removed half of that change in 1.63. Looks like he mistakenly thought it was a bug he introduced in 1.59. In fact, the change introduced in 1.63 broke HTTP error handling. To reproduce the bug, run the tests at the end of urllib2.py

The issue is that AbstractHTTPHandler no longer handles HTTP errors. HTTPErrorProcessor does that now.

Seems nobody remembers to run those tests. I wonder again whether at least some of them should live in the main test suite.