Issue 992055: socketmodule on OpenBSD/sparc64 (64bit machine) (original) (raw)

Issue992055

Created on 2004-07-16 00:47 by pelotas, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
patch pelotas,2004-07-16 00:47
Messages (3)
msg46376 - (view) Author: Aleksander Piotrowski (pelotas) Date: 2004-07-16 00:47
perky@users.sourceforge.net <perky@users.sourceforge.net> wrote: > Update of /cvsroot/python/python/dist/src/Modules > In directory sc8-pr-cvs1:/tmp/cvs-serv3617 > > Modified Files: > socketmodule.c > Log Message: > Fix erroneus argument parsing of socket.htons() on 64bit big endian > machines. This is cool but not enough. There is another place where 64 bit machines fail. Here is diff. With it my OpenBSD/sparc64 passes all socket tests (test_socket). Of course OpenBSD/i386 is still working OK. [diff attached] Hye-Shik Chang had already replied. Here is what he said: [...] But return value type of inet_addr(3) and its size has complex issues because it is used for not only OpenBSD but also BeOS, IRIX, old BSDs, Windows and etc. that I don't have an access. I think you'd better to submit it to SF tracker [...] So I'm submiting it.
msg46377 - (view) Author: Aleksander Piotrowski (pelotas) Date: 2004-07-16 00:50
Logged In: YES user_id=883833 Yuck. This looks ugly. Close this patch and I'll resubmit it. Sorry :/
msg46378 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-07-17 08:12
Logged In: YES user_id=21627 Ok, closed.
History
Date User Action Args
2022-04-11 14:56:05 admin set github: 40579
2004-07-16 00:47:33 pelotas create