Issue 997626: httplib.HTTPConnection.request() bug - Python tracker (original) (raw)

Created on 2004-07-25 17:56 by jjlee, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg46457 - (view)	Author: John J Lee (jjlee)	Date: 2004-07-25 17:56
996159 reveals a problem with httplib.HTTPConnection.request(). The underlying problem is that, while this method checks no explicit Host: header was provided, it fails to do the same for Accept-Encoding: and Content-Length: This patch fixes that.
msg46458 - (view)	Author: John J Lee (jjlee)	Date: 2004-07-25 18:00
Logged In: YES user_id=261020 This is important to get into 2.4, because it breaks urllib2. I haven't run the tests yet, or done any manual tests. I'll try and do that tomorrow.
msg46459 - (view)	Author: John J Lee (jjlee)	Date: 2004-07-25 18:09
Logged In: YES user_id=261020 Of course, urllib2 should also be fixed not to add Host and Content-Length headers (httplib makes a better job of it), but that's a separate bug which I'll file separately.
msg46460 - (view)	Author: John J Lee (jjlee)	Date: 2004-07-27 19:55
Logged In: YES user_id=261020 OK, I have now tested my patch, and uploaded a new one which is syntactically correct ;-) along with a patch for the test I added to test_httplib.py. No doc changes are required.