Message 103635 - Python tracker (original) (raw)

By the way, the patch looks good to me, as far as it goes, and I'm +1 on adding all this. I only have the tiniest of nits:

• the patch deletes a line at the top of Lib/test/test_datetime.py, for no apparent reason

• in delta_add, I think the added 'if' block should be an 'else if' (yes, I know this is excessively picky ;)

• the brace style for if blocks is inconsistent: please put the opening brace on the same line as the if.

One other thought: with this division operation added, it might be nice to add constants like td_hour, td_minute, etc. to the module. Then the perennial 'how can I convert my timedelta x to minutes' questions could be answered with 'just do x/td_minute'. I would personally find x/td_second to be a more obvious and natural way to find the total number of seconds in a timedelta than x.total_seconds. I also quite like the idea of being able to create a 2.5-hour timedelta with something like

2td_hour + 30td_minute

On the other hand, maybe such constants would just be added clutter, since it's easy to create them when needed.