Message 146647 - Python tracker (original) (raw)

Here is my quick review:

• shouldn't the opener also get the third open() argument (although it currently seems to always be 0o666)?
• when fdobj is NULL, you shouldn't override the original error
• PyLong_AsLong can fail (if the opener returns too large an int), you should check for that

Thank you!