Message 150501 - Python tracker (original) (raw)

Fine, I see what you mean, this involves very careful reading of the RFC and could have been a little more verbose ...

Right. Should have been a ')'

Adding the RFC tests would be great (patches gladly accepted). Fixes for ones we fail would be great, too, but at the very least we can mark them as expected failures. I don't usually like adding tests that we expect to fail, but in the case of externally defined tests such as the RFC examples I think it is worthwhile, so that we can check in a complete test set.

Patch attached (against current tip, 74241:120a79b8bb11). We currently fail all of the tests in the RFC due to the same problem, the closing ')', I've marked them accordingly.

I've made the 5th test (with newline in the string) two cases, one with \r\n for the newline, one with only \n. They fail differently.

I plan to look into this a little more, my current plan is to make the outer regex non-greedy (if possible) and remove the trailing whitespace. That would involve parsing (and ignoring) additional whitespace between encoded words but not at the boundary to a non-encoded word.

Any objections/further infos?

Ralf

Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting www: http://www.runtux.com Reichergasse 131, A-3411 Weidling email: office@runtux.com osAlliance member email: rsc@osalliance.com