Message 177890 - Python tracker (original) (raw)

Message177890

Author	meador.inge
Recipients	christian.heimes, dmalcolm, doko, lemburg, loewis, meador.inge, pitrou, skrah
Date	2012-12-21.19:51:49
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	1356119509.53.0.400862819802.issue16745@psf.upfronthosting.co.za
In-reply-to

Content
Personally I prefer using attributes instead of pragmas. The GCC manual recommends such as well. There are also other sources in Modules/* that use '__attribute__ ((visibility ("hidden")))'. Namely ctypes and zlib. I can understand that it is more work, but I find something like the following more readable (I am not actually suggesting names here, just an example): #define PY_LOCAL __attribute__ ((visibility ("hidden"))) ... void foo(void) PY_LOCAL; void bar(void) PY_LOCAL;

Content

Personally I prefer using attributes instead of pragmas. The GCC manual recommends such as well. There are also other sources in Modules/* that use '__attribute__ ((visibility ("hidden")))'. Namely ctypes and zlib. I can understand that it is more work, but I find something like the following more readable (I am not actually suggesting names here, just an example): #define PY_LOCAL __attribute__ ((visibility ("hidden"))) ... void foo(void) PY_LOCAL; void bar(void) PY_LOCAL;

History
Date	User	Action	Args
2012-12-21 19:51:49	meador.inge	set	recipients: + meador.inge, lemburg, loewis, doko, pitrou, christian.heimes, skrah, dmalcolm
2012-12-21 19:51:49	meador.inge	set	messageid: 1356119509.53.0.400862819802.issue16745@psf.upfronthosting.co.za
2012-12-21 19:51:49	meador.inge	link	issue16745 messages
2012-12-21 19:51:49	meador.inge	create