Message 196303 - Python tracker (original) (raw)

Thank you Ezio and Terry for reviews.

I presume you thought about it carefully in context.

Yes. Here can be any different types for which instances can be equal (1 == 1L, 1.0 == 1.0+0.0j).

This kind of changes are a bit out of place in a patch like this. They risk to introduce subtle problems and might go unnoticed during commit reviews.

I reverted code back to PyErr_SetString.

The only nontrivial changes are in Lib/pickletools.py, Lib/test/test_itertools.py and Lib/test/test_long.py (removed redundant handling of 'L' suffix in long representation).