Message 249286 - Python tracker (original) (raw)

Message249286

Author brett.cannon
Recipients alecsandru.patrascu, brett.cannon, gregory.p.smith, pitrou, scoder, skip.montanaro, skrah
Date 2015-08-28.18:35:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id 1440786906.76.0.872112360655.issue24915@psf.upfronthosting.co.za
In-reply-to
Content
I did another round of review. I noticed that the configure part of the patch is missing and that .hgignore and .gitignore should get updated to ignore the profile files. Otherwise the only other comment was making an echoed comment a bit clearer. And in case anyone else is on OS X Yosemite and gets an error about llvm-profdata missing, make sure that /Library/Developer/CommandLineTools/usr/bin is on your $PATH.
History
Date User Action Args
2015-08-28 18:35:06 brett.cannon set recipients: + brett.cannon, skip.montanaro, gregory.p.smith, pitrou, scoder, skrah, alecsandru.patrascu
2015-08-28 18:35:06 brett.cannon set messageid: 1440786906.76.0.872112360655.issue24915@psf.upfronthosting.co.za
2015-08-28 18:35:06 brett.cannon link issue24915 messages
2015-08-28 18:35:06 brett.cannon create