Message 258520 - Python tracker (original) (raw)

Message258520

Author	serhiy.storchaka
Recipients	Mark.Shannon, brett.cannon, gvanrossum, python-dev, rhettinger, serhiy.storchaka, vstinner
Date	2016-01-18.11:57:53
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	1453118273.97.0.244358939623.issue26107@psf.upfronthosting.co.za
In-reply-to

Content
Yes, you patch supersedes patch. Added new comments on Rietveld for lnotab_notes.txt. I afraid this patch can cause problems with code tracing where it is assumed that lines are increased monotonically and instr_lb <= frame->f_lasti < instr_ub. We should carefully analyze the effect of the patch on the tracing. Before committing you must ask Guido for approval. AFAIK his had objections against code transformations that make debugging harder.

Content

Yes, you patch supersedes patch. Added new comments on Rietveld for lnotab_notes.txt. I afraid this patch can cause problems with code tracing where it is assumed that lines are increased monotonically and *instr_lb <= frame->f_lasti < *instr_ub. We should carefully analyze the effect of the patch on the tracing. Before committing you must ask Guido for approval. AFAIK his had objections against code transformations that make debugging harder.

History
Date	User	Action	Args
2016-01-18 11:57:54	serhiy.storchaka	set	recipients: + serhiy.storchaka, gvanrossum, brett.cannon, rhettinger, vstinner, Mark.Shannon, python-dev
2016-01-18 11:57:53	serhiy.storchaka	set	messageid: 1453118273.97.0.244358939623.issue26107@psf.upfronthosting.co.za
2016-01-18 11:57:53	serhiy.storchaka	link	issue26107 messages
2016-01-18 11:57:53	serhiy.storchaka	create