Message 269323 - Python tracker (original) (raw)

I originally considered making two different patches, so there you go. deprecate_invalid_escapes_only_1.patch has the deprecation plus a test, and invalid_stdlib_escapes_1.patch fixes all invalid escapes in the stdlib.

My code was the cause, although no directly; it was 'assert(!PyErr_Occurred())' at the beginning of PyObject_Call in Objects/abstract.c which failed.

This happened when I ran the whole test suite (although just running test_ast was fine to reproduce it) with the '-W error' command line switch. One stdlib module (I don't remember which one) had one single invalid escape sequence in it, and then test_ast.ASTValidatorTests.test_stdlib_validates triggered the failed assertion. Fixing the invalid escape removes the failure and all tests pass.

One can reliably reproduce the crash with the patch by adding a string with an invalid escape in any of the stdlib files (and running with '-W error'):

No invalid sequence:

import unittest, test.test_ast unittest.main(test.test_ast) ..............................................................................

Ran 78 tests in 5.538s

With an invalid sequence in a file:

import unittest, test.test_ast unittest.main(test.test_ast) ............................................Fatal Python error: a function returned a result with an error set DeprecationWarning: invalid escape sequence 'w'

During handling of the above exception, another exception occurred:

SystemError: returned a result with an error set

Then I get the usual "Python has stopped working" Windows prompt (strangely enough, before I'd get a prompt saying "Assertion failed" with the line, but not this time).

I'm not sure where the error lies exactly. Should I open another issue for that?