Message 274326 - Python tracker (original) (raw)

I tried to post a comment on rietveld, but 500 infernal error...

PyUnicode_New(0, 0) will return unicode_empty. If unicode_empty is NULL, then it will also initialize it. It would be cleanest if unicode_empty was statically created.

NULL cannot be used as the separator argument to PyUnicode_Join(PyObject *separator, PyObject *seq) to mean an empty string, as it already means ' ' (space!).