Message 364461 - Python tracker (original) (raw)

Message364461

Author	Anthony Sottile
Recipients	Anthony Sottile, georg.brandl, maurosr, ncoghlan, pitrou, r.david.murray, serhiy.storchaka
Date	2020-03-17.17:37:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	1584466676.61.0.193310471331.issue25024@roundup.psfhosted.org
In-reply-to

Content
one example is here: https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/store.py#L137-L139 where I would want cleanup in the exceptional case another (related but different) closed-source use case involves creating a temporary directory that may be deleted and currently has to be guarded by: shutil.rmtree(..., ignore_errors=True) (making `TemporaryDirectory` not useful since it crashes if the directory goes missing) there's additionally the problem of readonly files on windows, and readonly directories elsewhere being undeletable without a custom rmtree but I think that's a different issue entirely -- https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/util.py#L250-L267

Content

one example is here: https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/store.py#L137-L139 where I would want cleanup in the exceptional case another (related but different) closed-source use case involves creating a temporary directory that may be deleted and currently has to be guarded by: shutil.rmtree(..., ignore_errors=True) (making `TemporaryDirectory` not useful since it crashes if the directory goes missing) there's additionally the problem of readonly files on windows, and readonly directories elsewhere being undeletable without a custom rmtree but I think that's a different issue entirely -- https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/util.py#L250-L267

History
Date	User	Action	Args
2020-03-17 17:37:56	Anthony Sottile	set	recipients: + Anthony Sottile, georg.brandl, ncoghlan, pitrou, r.david.murray, serhiy.storchaka, maurosr
2020-03-17 17:37:56	Anthony Sottile	set	messageid: 1584466676.61.0.193310471331.issue25024@roundup.psfhosted.org
2020-03-17 17:37:56	Anthony Sottile	link	issue25024 messages
2020-03-17 17:37:56	Anthony Sottile	create