Message 94875 - Python tracker (original) (raw)

A couple of points:

• if the method is Windows-specific, I don't think it shouldn't bear a name as generic as "read_registry()". There are "registries" on other systems.
• the method should probably raise early on non-Windows systems (raise NotImplementedError?)
• please fix the coding style; don't collapse a "try", "except" or "finally" and the following statement on a single line
• in the tests, rather than defining an empty test case on non-Windows systems, make the tests skip (for example, call self.skipTest()