[FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523) (original) (raw)
Daniel Kang daniel.d.kang
Sat Jan 15 02:31:36 CET 2011
- Previous message: [FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523)
- Next message: [FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Jan 12, 2011 at 1:43 AM, Kostya <kostya.shishkov at gmail.com> wrote:
On Tue, Jan 11, 2011 at 05:00:55PM -0500, Daniel Kang wrote: > On Tue, Jan 11, 2011 at 4:21 PM, Kostya <kostya.shishkov at gmail.com> wrote: > > > On Tue, Jan 11, 2011 at 03:26:19PM -0500, Daniel Kang wrote: > > > On Tue, Jan 11, 2011 at 11:24 AM, Michael Niedermayer <_ _michaelni at gmx.at_ _> > >wrote: > > > > > [...] > > > > > > > > this is a error condition and continuing with undefined values makes no > > > > sense > > > > also i suspect only one of teh 2 checks is needed > > > > > > > > > I have updated the message and return an error. The invalid sym in this > > > case are -1. I am not sure if the other check is needed, as the sample > > > file does not encounter values greater than 256. > > > > else{} is not needed there, just move assignment under the check > > > Patch updated without the else.
looks ok
Are there any more comments or can this be commited?
- Previous message: [FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523)
- Next message: [FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]